Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login command should always look for new accounts #576

Closed
synfinatic opened this issue Sep 29, 2023 · 1 comment
Closed

login command should always look for new accounts #576

synfinatic opened this issue Sep 29, 2023 · 1 comment
Labels
caching enhancement New feature or request
Milestone
2.0.0 - aborted

Comments

@synfinatic
Copy link
Owner

In theory, the sso:ListAccounts call should be fast enough (one or two API calls max?) to always run as a quick means of cache validation. Of course, if your admin has merely added a role to an existing account this won't help, but probably a majority of roles assigned will be for new accounts? At least that's the theory. Should reduce complaints about caching.
@synfinatic synfinatic added the enhancement New feature or request label Sep 29, 2023
@synfinatic synfinatic added this to the v1.14.0 milestone Sep 29, 2023
@synfinatic
Copy link
Owner Author

synfinatic commented Sep 29, 2023 •
edited
Loading

Note: this requires a valid SSO session for this API to work. So instead, we should use the login command as the trigger.

@synfinatic synfinatic modified the milestones: v1.14.0, 1.15.0 Oct 14, 2023
@synfinatic synfinatic changed the title list command should always look for new accounts login command should always look for new accounts Oct 21, 2023
synfinatic added a commit that referenced this issue Oct 28, 2023
@synfinatic
login command checks AWS account list
453bea2 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
@synfinatic synfinatic mentioned this issue Oct 28, 2023
Merged
synfinatic added a commit that referenced this issue Oct 28, 2023
@synfinatic
login command checks AWS account list

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b5e1e0a 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
synfinatic added a commit that referenced this issue Oct 28, 2023
@synfinatic
login command checks AWS account list
b2f13ab 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
synfinatic added a commit that referenced this issue Oct 28, 2023
@synfinatic
login command checks AWS account list
cf6697a 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
synfinatic added a commit that referenced this issue Oct 31, 2023
@synfinatic
remove --no-config-check from shell integration
2da2009 
Refs: #576
@synfinatic synfinatic mentioned this issue Oct 31, 2023
Merged
synfinatic added a commit that referenced this issue Jan 11, 2024
@synfinatic
login command checks AWS account list
4326a9e 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
synfinatic added a commit that referenced this issue Jan 15, 2024
@synfinatic
login command checks AWS account list
9cf2c21 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
synfinatic added a commit that referenced this issue Jan 15, 2024
@synfinatic
remove --no-config-check from shell integration
bcb2002 
Refs: #576
synfinatic added a commit that referenced this issue Jan 15, 2024
@synfinatic
login command checks AWS account list
4b6eb13 
Every time you login we do a quick validation that the
list of accounts you have access to doesn't change,
and will trigger a cache refresh if there are changes.

Fixes: #576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
caching enhancement New feature or request
Projects
None yet
Milestone
2.0.0 - aborted
Development

No branches or pull requests
1 participant
@synfinatic