leveldb: Don't crash when using a released snapshot#320
Merged
syndtr merged 1 commit intosyndtr:masterfrom Aug 15, 2020
Merged
Conversation
The snapshot has a mutex and a `released` bool, but the access methods touch `db` before looking at `released`. The `db` is set to nil when the snap is released. Hence ErrSnapshotReleased is never returned, instead the program panics with a nil deref.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snapshot has a mutex and a
releasedbool, but the access methodstouch
dbbefore looking atreleased. Thedbis set to nil when thesnap is released. Hence ErrSnapshotReleased is never returned, instead
the program panics with a nil deref.