ST2-385 Actions and class file added #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Greyjacket Before you request a review, what of the checklist in the PR can you complete? |
btackett3
reviewed
Feb 3, 2020
| try: | ||
| response_dict = response[1].json() | ||
| except: | ||
| return True, {'result': 'Policy successfully changed'} |
There was a problem hiding this comment.
Why would an exception here not mean failure?
There was a problem hiding this comment.
I believe I had some issues converting the returned json to a dictionary. We check for a 200 in the earlier call to response[0], so we can be certain that the policy has been changed by the time we arrive here.
punkrokk
requested changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cylance Protect Pull Request:
Summary of Changes:
Cylance Protect Actions and Class file added
New Packs
Delete if not a new pack
Checklist:
Please complete the following for the PR to be reviewed.
is at and what the purpose of the PR is quickly
Fixes for Issue(s)/Ticket(s):
Reference the GitHub Issue(s) or open tickets this PR addresses (if any).