Sandbox Default #353
Merged
Sandbox Default #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Rash <[email protected]>
autodidaddict
approved these changes
Aug 14, 2024
jordan-rash
added a commit
that referenced
this pull request
Aug 16, 2024
This reverts commit e5e569c.
jordan-rash
added a commit
that referenced
this pull request
Aug 16, 2024
* Revert "remove nosandbox default (#353)" * only override config if cli is true This reverts commit e5e569c. --------- Signed-off-by: Jordan Rash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the default on the --no-sandbox flag was overriding the config everytime....this checks before it overrides