Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevents a panic during shutdown when there's no NATS connection #304

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

autodidaddict
Copy link
Contributor

Prevents the panic as described in #277

@autodidaddict autodidaddict requested a review from a team as a code owner July 1, 2024 14:47
@autodidaddict
Copy link
Contributor Author

New output when the node shuts down during startup:

[INF] 2024-07-01 10:48:43 - Loaded node configuration config_path=/home/kevin/nosandbox.json
[INF] 2024-07-01 10:48:43 - Telemetry status metrics=false traces=false
[ERR] 2024-07-01 10:48:43 - Failed to connect to NATS server err=nats: no servers available for connection
[INF] 2024-07-01 10:48:43 - Internal NATS server started client_url=nats://0.0.0.0:34307
[INF] 2024-07-01 10:48:43 - Host services configured services=[http kv messaging objectstore]
[WRN] 2024-07-01 10:48:43 - ⚠️  Sandboxing has been disabled! Workloads are spawned directly by agents
[WRN] 2024-07-01 10:48:43 - ⚠️  Do not run untrusted workloads in this mode!
[INF] 2024-07-01 10:48:43 - Workload manager stopping
[INF] 2024-07-01 10:48:43 - Spawning process manager stopping

@autodidaddict autodidaddict linked an issue Jul 1, 2024 that may be closed by this pull request
@autodidaddict autodidaddict merged commit c9aa165 into main Jul 1, 2024
5 checks passed
@autodidaddict autodidaddict deleted the fix/safedrain branch July 1, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when starting node without nats-server running
2 participants