Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a timeout to mmds queries #3

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Adds a timeout to mmds queries #3

merged 2 commits into from
Dec 18, 2023

Conversation

autodidaddict
Copy link
Contributor

Mmds should respond immediately. If it takes a "long time" or worse, forever, then that's a clear indication something is wrong with firecracker, the network, or both. To avoid hanging indefinitely in these situations, this adds a 1 second max timeout.

Copy link
Contributor

@sethjback sethjback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kthomas kthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@autodidaddict autodidaddict merged commit 9a68e7e into main Dec 18, 2023
@kthomas kthomas deleted the fix/httptimeout branch December 22, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants