formalizes the host services contract, creates explicit client and server #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure why the tests are failing, and it looks like they're not failing as a result of the new code here. Given people's lack of availability this week, I wonder if it makes sense to merge this and then fix the tests in a separate effort? |
|
This addresses #170 |
kthomas
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a lot of changes, but mostly it's just been relocating and simplifying code. I also created a standard envelope used for responses from host services so that it would be easy to tell errors from success without knowing the individual service's payload type.
Because of the new interface used for host services, the
request manyfunction on messaging is currently commented out. Rather than delaying all this work for the one function, I'm okay with leaving it disabled in main for a little while until I can come up with a good way of supporting this kind of functionality for host services.