Build and run on windows #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthomas
force-pushed
the
feat/windows-specs
branch
5 times, most recently
from
50fe55e
to
30bb796
Compare
kthomas
force-pushed
the
feat/windows-specs
branch
18 times, most recently
from
1e861f0
to
84dedea
Compare
kthomas
force-pushed
the
feat/windows-specs
branch
2 times, most recently
from
2a615cc
to
efe5ea6
Compare
kthomas
force-pushed
the
feat/windows-specs
branch
from
8705fbe
to
e53f717
Compare
|
I can't digest a PR of this size. I think the only option is to merge it and then deal with the consequences in multiple smaller PRs after this. So let's call my approval of this PR a begrudging approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional build tags to ensure
nexcan build and run on Windows.