Add support for starting a userland NATS server #197
Conversation
|
It would be great if there was another JSON file in the sample configs section that showed the public NATS configuration |
|
Should we validate that the provided options for the public NATS connection match the public NATS server config? As it currently stands, the code will allow a public NATS server to be configured and the NATS connection could still connect successfully to a different NATS server. |
Let's not do that yet. We shouldn't assume that the userland NATS server being started has anything do with nex other than its packaging. |
| n.log.Error("Failed to start internal NATS server", slog.Any("err", err)) | ||
| err = fmt.Errorf("failed to start internal NATS server: %s", err) | ||
| // start internal NATS server | ||
| _err = n.startInternalNATS() |
There was a problem hiding this comment.
this looks a little awkward. The underscore prefix typically indicates that the variable isn't being used, but this variable is used in multiple places.
| err = n.api.Start() | ||
| if err != nil { | ||
| n.log.Error("Failed to start API listener", slog.Any("err", err)) | ||
| if err == nil { |
There was a problem hiding this comment.
could this just be an else clause to the previous if _err != nil ?
This PR allows users to configure and start a "userland" NATS server when starting a node.
Error handling inside of
node.init()was not failing fast, resulting in discarded errors. This PR includes a fix to useerrors.Joinwhich allows the node to gracefully abort initialization usingshutdown()instead of panicking.Closes #168.