Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide OTel solution for local development #182

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Provide OTel solution for local development #182

merged 7 commits into from
Apr 18, 2024

Conversation

jordan-rash
Copy link
Contributor

No description provided.

@jordan-rash jordan-rash requested a review from a team as a code owner April 17, 2024 12:37
autodidaddict
autodidaddict previously approved these changes Apr 17, 2024
@autodidaddict
Copy link
Contributor

Having trouble seeing the CLI support behavior. if you specify the trace exporter via command line, does that override what's inside the config file?

@jordan-rash
Copy link
Contributor Author

Having trouble seeing the CLI support behavior. if you specify the trace exporter via command line, does that override what's inside the config file?

Thats because your too fast for me. Check now

@autodidaddict
Copy link
Contributor

autodidaddict commented Apr 17, 2024

Having trouble seeing the CLI support behavior. if you specify the trace exporter via command line, does that override what's inside the config file?

Thats because your too fast for me. Check now

I still can't find where the CLI-supplied values override the config-file value 👀
From the code I'm looking at, it looks like it only uses the configuration file value and the CLI values are ignored

@jordan-rash
Copy link
Contributor Author

jordan-rash commented Apr 17, 2024

Having trouble seeing the CLI support behavior. if you specify the trace exporter via command line, does that override what's inside the config file?

Thats because your too fast for me. Check now

I still can't find where the CLI-supplied values override the config-file value 👀 From the code I'm looking at, it looks like it only uses the configuration file value and the CLI values are ignored

Oh, the CLI doesnt overwrite the otlp_exporter_url option. All thats added is a bool to actually use trace (irregardless of the state of otlp_exporter_url) and which exporter to use (which at the moment, there is only one -> grpc).
If I added the two CLI values to the config file, that was unintentional and I can remove that

@kthomas
Copy link
Contributor

kthomas commented Apr 17, 2024

This just needs to be rebased on main to fix the linting issue.

@jordan-rash jordan-rash merged commit 889bf3d into main Apr 18, 2024
4 checks passed
@jordan-rash jordan-rash deleted the fix/otel branch April 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants