adds the spawning process manager to run with scissors

[autodidaddict]

No description provided.

[kthomas]

Why don't we want to handle signals in the Agent? It would seemingly make even more sense to support signal handling in no-sandbox mode.

[autodidaddict]

We are handling signals. We weren't before. I'm just not using a channel to do it . In the code prior to this PR, we had the sigs channel but there was nothing sending to it... so basically we had a part of a select that would never fire.

Now instead of using the sigs channel, we're just using the same signal handler pattern we use in the node

[kthomas]

The node uses a channel to ensure signals are handled serially. We can fix this to make it work like the node does later.

[kthomas]

Similar concern regarding use of os.Exit here in setupSignalHandlers.

[jordan-rash]

https://pkg.go.dev/runtime#Goexit

[kthomas]

Not sure we need Goexit here either, although this is interesting.

[jordan-rash]

well, my point is, even if there are no defers before this Exit right YET, we shouldn't be using it at all.

[jordan-rash]

This all looks good to me, only nits. That said, I still need to put all the changes from 155 apart to understand the full flow of everthing now, just havent had time yet

[jordan-rash]

https://pkg.go.dev/runtime#Goexit

[autodidaddict]

@jordan-rash the runtime Goexit only affects the current goroutine... it doesn't actually terminate the application. This means we could add a go statement somewhere else in the code and this would stop exiting

Just from a quick glance I can see at least 4 other go routines that would be running at the time Goexit was called.

From the docs:

Calling Goexit from the main goroutine terminates that goroutine without func main returning. Since func main has not returned, the program continues execution of other goroutines. If all other goroutines exit, the program crashes.

This seems like a particularly dangerous way to exit an application. It explicitly doesn't shut the app down or even finish the main func

[kthomas]

I will update the spec suite in a new PR.