allow agent to pull its metadata from environment #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthomas
reviewed
Apr 2, 2024
kthomas
reviewed
Apr 2, 2024
kthomas
reviewed
Apr 2, 2024
kthomas
previously approved these changes
Apr 2, 2024
Addressed your items |
kthomas
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to eventually support the no-sandbox mode, agents will need a way to get the NATS internal IP and port and the workloadId that it's been assigned from the node.
This PR makes it so that if the
NEX_SANDBOXenvironment variable both exists and contains the value "false", then the agent will skip the MMDS query. When the agent is running in a sandbox (firecracker + rootfs), the agent is running as an openrc service and so won't have that env var.