Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngs needs this value set to create streams #144

Merged
merged 2 commits into from
Mar 19, 2024
Merged

ngs needs this value set to create streams #144

merged 2 commits into from
Mar 19, 2024

Conversation

jordan-rash
Copy link
Contributor

No description provided.

@jordan-rash jordan-rash requested a review from a team as a code owner March 19, 2024 09:25
autodidaddict
autodidaddict requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@autodidaddict autodidaddict left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only 500kb for the binary. If we're going to hardcode a max for now, let's hard code it at a higher value, like 100mb

autodidaddict
autodidaddict approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@autodidaddict autodidaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore me. I thought we were setting max bytes on an object store.

@jordan-rash jordan-rash merged commit 46440a3 into main Mar 19, 2024
3 checks passed
@jordan-rash jordan-rash deleted the fix/ngs_friendly_config branch March 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autodidaddict autodidaddict autodidaddict approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordan-rash @autodidaddict