Adds block to prevent deploying to un-handshake'd VM, shuts node down if first handshake fails #136
Conversation
Signed-off-by: Kevin Hoffman <[email protected]>
| @@ -352,133 +355,6 @@ func (m *MachineManager) awaitHandshake(vmid string) { | |||
| } | |||
| } | |||
|
|
|||
| // Called when the node server gets a log entry via internal NATS. Used to | |||
There was a problem hiding this comment.
I kinda liked having all of the MachineManager code in the same place. Maybe it doesn't matter too much. @jordan-rash do you have an opinion?
There was a problem hiding this comment.
I start to itch when we get over the 500 line mark. While yes it's all under the machine manager umbrella, I like having logically related stuff in nearby locations.
There was a problem hiding this comment.
I start to itch when we get over the 500 line mark. While yes it's all under the machine manager umbrella, I like having logically related stuff in nearby locations.
Makes sense. It would be better if we created a new interface and struct to make things more readable imho instead of separating it into separate files. I will not die on this hill though.
Closes #134
Don't worry about the large "delete" portion of the diff, I just moved a bunch of related functions into their own file to try and keep the
machine_mgr.gofile to a manageable size.