Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Pages Installer #106

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Github Pages Installer #106

merged 5 commits into from
Feb 1, 2024

Conversation

jordan-rash
Copy link
Contributor

add installer to github pages for easy button

@jordan-rash jordan-rash requested a review from a team as a code owner February 1, 2024 19:22
@jordan-rash
Copy link
Contributor Author

Confirmed this works as expected on jordan-rash/nex

autodidaddict
autodidaddict requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@autodidaddict autodidaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit

README.md Outdated Show resolved Hide resolved
autodidaddict
autodidaddict approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@autodidaddict autodidaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to make sure we update docs.nats.io 's getting started guide, too

@jordan-rash jordan-rash merged commit c304ecf into main Feb 1, 2024
4 checks passed
@jordan-rash jordan-rash deleted the ci/ghp_installer branch February 1, 2024 21:03
@jordan-rash jordan-rash mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autodidaddict autodidaddict autodidaddict approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordan-rash @autodidaddict