-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves & Fixes Issue #70 | plot() doesn't produce an error now #72
Conversation
I think the only change here should be the requirements.txt file. You have mixed in changes from other pull requests. Make sure when you start a new branch that you |
Could you create a new pull request with a new branch, which is based off of master, with just the change to the requirements file. If the fix really is correct, the phantom.js change should not be necessary. |
If the phantom.js change is needed then you haven't really fixed the issue, because all the phantom.js change does is disable the test. I am -1 to the phantom.js change. |
Ohh @asmeurer . I'll try pushing a PR with only the requirements.txt change. |
The |
So, I'll close this PR, since #70 is merged. |
@asmeurer .
This PR solves and fixes issue #70 . plot() no longer gives an error. The main error was because of the
numpy
anddjango
version on my system, my local installation ofnumpy
anddjango
were very new version's in comparison to those compatible with SymPy Gamma, as of now. Re-installing the required versions ofnumpy
anddjango
solved the issue! Hence, I modified the test case file, as well as the requirements file. Now, plot() card in my local installation of SymPy Gamma doesn't produce any error, and displays the required graph.Hence, this fixes & resolves issue #70 .
The same can be observed in this screenshot-: