Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP7 Compatibility release #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension.driver.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static function registerProviders()
return true;
}

public static function providerOf($type = null)
public function providerOf($type = null)
{
self::registerProviders();

Expand Down Expand Up @@ -72,5 +72,5 @@ public function uninstall()
{
Symphony::Configuration()->remove('remote_datasource');
}

}
124 changes: 59 additions & 65 deletions extension.meta.xml
Original file line number Diff line number Diff line change
@@ -1,68 +1,62 @@
<?xml version="1.0" encoding="UTF-8"?>
<extension id="remote_datasource" status="released" xmlns="http://getsymphony.com/schemas/extension/1.0">
<name>Remote Datasource</name>
<description>A datasource that consumes XML, JSON, CSV or TEXT content.</description>
<repo type="github">https://github.com/symphonycms/remote_datasource</repo>
<url type="issues">https://github.com/symphonycms/remote_datasource/issues</url>
<url type="discuss">https://www.getsymphony.com/discuss/thread/110527/</url>
<authors>
<author>
<name github="symphonycms" symphony="team">Symphony Team</name>
</author>
</authors>
<releases>
<release version="2.4.0" date="2019-03-01" min="2.6" max="3.x.x">
- Pass namespace to the cacheable instance
</release>
<release version="2.3.1" date="2019-02-27" min="2.4" max="3.x.x">
- [#37](https://github.com/symphonycms/remote_datasource/issues/37) Fix error when multiple datasources are added to the same page with different formats.
</release>
<release version="2.3.0" date="2017-07-12" min="2.4" max="3.x.x">
- Bug fixes
- Added compatibility with Symphony 2.7.x and 3.x.x
</release>
<release version="2.2.1" date="2015-12-01" min="2.4" max="2.6.x">
- Fix for php 5.3 compat
</release>
<release version="2.2.0" date="2015-06-24" min="2.4" max="2.6.x">
- Make CSV style configurable.
- Fix `{$workspace}` path
</release>
<release version="2.1.3" date="2015-05-13" min="2.4" max="2.6.x">
- Fix a bug with late static binding on PHP 5.3.
</release>
<release version="2.1.2" date="2014-12-17" min="2.4" max="2.6.x">
- Fix the first cache of a result always resulting in an error
- Abstract the transformers for better extensibility
</release>
<release version="2.1.1" date="2014-09-28" min="2.4">
- Expose the CURL error via `httpError()`
- Fix error with CSV importing
</release>
<release version="2.1.0" date="2014-06-25" min="2.4">
- Add support for text format (a copy of the html response body)
- Add some documentation
</release>
<release version="2.0.1" date="2014-06-24" min="2.4">
- Clean-up
</release>
<release version="2.0.0" date="2014-05-06" min="2.4">
- Add support for Symphony 2.4
- Support CSV data format
- Allow `$gateway` to be manipulated and `$data` to previewed
- When the Datasource fails, data is added to the `?debug` page to assist in debugging
- Allow no cache to be set
- Sanitize XPath to allow for more complex queries
</release>
<release version="1.1.0" date="2013-02-19" min="2.3" max="2.4">
- Officially release the extension
- Add `url` to the resulting XML result so you can see what URL was actually fetched
- Fix bug where a result would always be `stale`
- Allow timeout to be user configurable in the Data Source Editor
- Various PHP E_NOTICE fixes
</release>
<release version="1.0.0" date="2012-03-11" min="2.3">
- Initial release
</release>
</releases>
<name>Remote Datasource</name>
<description>A datasource that consumes XML, JSON, CSV or TEXT content.</description>
<repo type="github">https://github.com/symphonycms/remote_datasource</repo>
<url type="issues">https://github.com/symphonycms/remote_datasource/issues</url>
<url type="discuss">http://www.getsymphony.com/discuss/thread/110527/</url>
<authors>
<author>
<name github="symphonycms" symphony="team">Symphony Team</name>
</author>
</authors>
<releases>
<release version="3.0.0" date="TBA" min="4.0.0" max="4.x.x" php-min="5.6.x" php-max="7.x.x">
- Update for Symphony 4.x
- PHP7 Compatibility
</release>
<release version="2.2.1" date="2015-12-01" min="2.4" max="2.6.x">
- Fix for php 5.3 compat
</release>
<release version="2.2.0" date="2015-06-24" min="2.4" max="2.6.x">
- Make CSV style configurable.
- Fix `{$workspace}` path
</release>
<release version="2.1.3" date="2015-05-13" min="2.4" max="2.6.x">
- Fix a bug with late static binding on PHP 5.3.
</release>
<release version="2.1.2" date="2014-12-17" min="2.4" max="2.6.x">
- Fix the first cache of a result always resulting in an error
- Abstract the transformers for better extensibility
</release>
<release version="2.1.1" date="2014-09-28" min="2.4">
- Expose the CURL error via `httpError()`
- Fix error with CSV importing
</release>
<release version="2.1.0" date="2014-06-25" min="2.4">
- Add support for text format (a copy of the html response body)
- Add some documentation
</release>
<release version="2.0.1" date="2014-06-24" min="2.4">
- Clean-up
</release>
<release version="2.0.0" date="2014-05-06" min="2.4">
- Add support for Symphony 2.4
- Support CSV data format
- Allow `$gateway` to be manipulated and `$data` to previewed
- When the Datasource fails, data is added to the `?debug` page to assist in debugging
- Allow no cache to be set
- Sanitize XPath to allow for more complex queries
</release>
<release version="1.1.0" date="2013-02-19" min="2.3" max="2.4">
- Officially release the extension
- Add `url` to the resulting XML result so you can see what URL was actually fetched
- Fix bug where a result would always be `stale`
- Allow timeout to be user configurable in the Data Source Editor
- Various PHP E_NOTICE fixes
</release>
<release version="1.0.0" date="2012-03-11" min="2.3">
- Initial release
</release>
</releases>
</extension>
2 changes: 1 addition & 1 deletion templates/blueprints.datasource.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class datasource<!-- CLASS NAME --> extends RemoteDatasource {

<!-- PARAMOUTPUT -->

public function __construct($env=NULL, $process_params=true)
public function __construct($env = null, $process_params = true)
{
parent::__construct($env, $process_params);
$this->_dependencies = array(<!-- DS DEPENDENCY LIST -->);
Expand Down