Skip to content

Conversation

@stof
Copy link
Member

@stof stof commented May 16, 2018

What gets extracted in this chunk is not the manifest (which creates confusion with the webpack manifest which is a JSON file used by the backend code, i.e. the Symfony asset component); it is the webpack runtime.

This runtime indeed includes some information also present in the manifest (it contains the mapping for all dynamic chunks), but that's not all of it.

@stof
Copy link
Member Author

stof commented May 16, 2018

Next question is whether we should rename the output file from manifest.js to runtime.js (matching the default name used by Webpack 4 when enabling such feature).

This would reduce the confusion between manifest.js (the runtime file) and manifest.json (the manifest). But that would be a BC break (as projects have to load this runtime file in their HTML).

Copy link
Collaborator

@Lyrkan Lyrkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about modifying the name of that file yet.

I think it'd be easier to justify that change after switching to Webpack 4 which will probably also introduce some other BC breaks related to common chunks.

@stof
Copy link
Member Author

stof commented May 16, 2018

yeah, delaying this until the Webpack 4 migration might be fine.

@weaverryan
Copy link
Member

It's so confusing, I even typo'ed it in my notes :p. And yes, I think we should rename this - runtime.js is much more clear. It's already done on the Webpack 4 branch.

@weaverryan weaverryan merged commit 992845e into master May 19, 2018
weaverryan added a commit that referenced this pull request May 19, 2018
This PR was merged into the master branch.

Discussion
----------

Update the description of the webpack runtime chunk

What gets extracted in this chunk is not the manifest (which creates confusion with the webpack manifest which is a JSON file used by the backend code, i.e. the Symfony asset component); it is the webpack runtime.

This runtime indeed includes some information also present in the manifest (it contains the mapping for all dynamic chunks), but that's not all of it.

Commits
-------

992845e Update the description of the webpack runtime chunk
@stof stof deleted the stof-patch-1 branch January 30, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants