Fix 'plugin' typehint on Encore.addPlugin #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `plugin` parameter is describes as `{string}` but in fact we want to have instances of a Webpack plugin here. So I think we should use `object` here, which reflects the fact that all examples and known usages use an object there...
stof
approved these changes
Feb 15, 2018
Lyrkan
approved these changes
Feb 15, 2018
Member
|
Thank you Christoph! |
weaverryan
added a commit
that referenced
this pull request
Feb 28, 2018
This PR was merged into the master branch.
Discussion
----------
Fix 'plugin' typehint on Encore.addPlugin
The `plugin` parameter is described as `{string}` but in fact we want to have instances of a Webpack plugin here. So I think we should use `object` here, which reflects the fact that all examples and known usages use an object there...
Commits
-------
6d9525a Fix 'plugin' typehint on Encore.addPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pluginparameter is described as{string}but in fact we want to have instances of a Webpack plugin here. So I think we should useobjecthere, which reflects the fact that all examples and known usages use an object there...