Add Encore.enableBuildNotifications() method #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow! Once again, this is just really nice work. I'm super excited about this feature :) |
weaverryan
added a commit
that referenced
this pull request
Oct 31, 2017
This PR was merged into the master branch. Discussion ---------- Add Encore.enableBuildNotifications() method This PR adds an `enableBuildNotifications()` method to the public API in order to use the `webpack-notifier` plugin (closes #187): ```js // With default options Encore.enableBuildNotifications(); // Conditionally Encore.enableBuildNotifications(!Encore.isProduction()); // With custom options Encore.enableBuildNotifications(true, (options) => { options.title = 'Foo'; }); ``` The plugin is disabled by default and needs to be installed manually using `yarn add --dev webpack-notifier`. Commits ------- 6fec895 Add Encore.enableBuildNotifications() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
enableBuildNotifications()method to the public API in order to use thewebpack-notifierplugin (closes #187):The plugin is disabled by default and needs to be installed manually using
yarn add --dev webpack-notifier.