Add an instance of DefinePlugin even in development mode #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

weaverryan merged 1 commit into symfony:master from Lyrkan:fix-define-plugin-development

Oct 6, 2017

Collaborator

Lyrkan commented Oct 4, 2017

This PR fixes #171 by adding an instance of the DefinePlugin to the generated Webpack config no matter what the current environment is.


          Add an instance of DefinePlugin even in development mode

ee511dc

weaverryan merged commit 5cad839 into symfony:master

Member

weaverryan commented Oct 6, 2017

Ah yes, definitely a good fix! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet