Skip to content

Conversation

@stof
Copy link
Member

@stof stof commented Aug 30, 2024

Those lines don't report such error.

@stof
Copy link
Member Author

stof commented Aug 30, 2024

Should I addthe --report-unused-disable-directives flag in the lint script in our package.json ?

@stof stof changed the title REmove useless eslint disabling comments Remove useless eslint disabling comments Aug 30, 2024
@Kocal
Copy link
Member

Kocal commented Aug 30, 2024

Should I add the --report-unused-disable-directives flag in the lint script in our package.json ?

Yes please, it would help to remove useless directives.

Those lines don't report such error.
@Kocal Kocal force-pushed the clear_eslint_disables branch from 56b62dd to dcfdae1 Compare August 31, 2024 09:08
@Kocal
Copy link
Member

Kocal commented Aug 31, 2024

Thanks @stof, I've added the flag to the lint npm script.

@Kocal Kocal merged commit a6cf19f into symfony:main Aug 31, 2024
@stof stof deleted the clear_eslint_disables branch September 2, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants