Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

[2.6+] Removed AcmeDemoBundle#819

Merged
fabpot merged 2 commits intosymfony:2.6from
javiereguiluz:remove_acme_demo_bundle
Jun 11, 2015
Merged

[2.6+] Removed AcmeDemoBundle#819
fabpot merged 2 commits intosymfony:2.6from
javiereguiluz:remove_acme_demo_bundle

Conversation

@javiereguiluz
Copy link
Copy Markdown
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This removes the AcmeDemoBundle for Symfony Standard 2.6+.

@javiereguiluz javiereguiluz changed the title Removed AcmeDemoBundle [2.6+] Removed AcmeDemoBundle Jun 5, 2015
@Pierstoval
Copy link
Copy Markdown
Contributor

👍 What about 2.7 also?

@javiereguiluz
Copy link
Copy Markdown
Member Author

@Pierstoval 2.7 is included too. This PR is for any Symfony version higher than 2.6.

@GrahamCampbell
Copy link
Copy Markdown
Contributor

This is not a bug fix, so surely it's not allowed into 2.6, and must go into 2.7+.

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jun 5, 2015

@GrahamCampbell Symfony SE works in a different way than Symfony. The versions reflect the Symfony version for which SE is tied with. Nobody upgrades its Symfony SE, it's just a starting point for new projects.

@Tobion
Copy link
Copy Markdown
Contributor

Tobion commented Jun 11, 2015

👍

1 similar comment
@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Jun 11, 2015

👍

@weaverryan
Copy link
Copy Markdown
Contributor

We're ready on the docs (a few spots still mention AcmeDemoBundle, but I don't think it's an issue). Can anyone think of any other side effects we haven't covered yet?

Regardless, 👍

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jun 11, 2015

Thank you @javiereguiluz.

@fabpot fabpot merged commit 42b1224 into symfony:2.6 Jun 11, 2015
fabpot added a commit that referenced this pull request Jun 11, 2015
This PR was merged into the 2.6 branch.

Discussion
----------

[2.6+] Removed AcmeDemoBundle

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This removes the AcmeDemoBundle for Symfony Standard 2.6+.

Commits
-------

42b1224 The security.yml file now uses the same configuration as in Symfony 2.3 (the "default" firewall is now called "main")
eb4a8e1 Removed AcmeDemoBundle
@javiereguiluz javiereguiluz deleted the remove_acme_demo_bundle branch July 22, 2015 07:28
weaverryan added a commit to symfony/symfony-docs that referenced this pull request Aug 2, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #6796).

Discussion
----------

Remove AcmeDemoBundle references

After symfony/symfony-standard#819 and symfony/symfony-standard#818 last year the AcmeDemoBundle doesn't exist so having an article dedicated to it doesn't appear to make much sense. This adapts the article to be focused on removing 'a bundle'.

Commits
-------

9476cfa Remove AcmeDemoBundle references
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants