This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Use Symfony's helper to format the memory values #283
Merged
+3
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelandrieu
approved these changes
Oct 10, 2016
javiereguiluz
added a commit
that referenced
this pull request
Oct 12, 2016
…uiluz) This PR was merged into the 1.0-dev branch. Discussion ---------- Use Symfony's helper to format the memory values Less code to maintain for us and the output is almost the same: ### Before  ### After  --- Thanks to @mickaelandrieu who tweeted about this helper method and allowed me to learn about it! Commits ------- c3f8200 Use Symfony's helper to format the memory values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less code to maintain for us and the output is almost the same:
Before
After
Thanks to @mickaelandrieu who tweeted about this helper method and allowed me to learn about it!