This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Allow to execute the symfony demo command repeatedly
#167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jun 10, 2015
…ereguiluz)
This PR was merged into the 1.0-dev branch.
Discussion
----------
Allow to execute the `symfony demo` command repeatedly
If `-> addArgument()` provides a default value for the `directory` argument, then the `!$input->getArgument('directory')` instruction will never be `true`. The result is that you cannot execute the `symfony demo` command repeatedly as you could in the previous versions:
Commits
-------
182babb Allow to execute the `symfony demo` command repeatedly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
-> addArgument()provides a default value for thedirectoryargument, then the!$input->getArgument('directory')instruction will never betrue. The result is that you cannot execute thesymfony democommand repeatedly as you could in the previous versions: