Skip to content

Conversation

@mickaelandrieu
Copy link
Contributor

Before 3.1 we need both console name and version in order to display the console name instead of console tool, now we only need to setup the name.

See symfony/console@56eb96d

@javiereguiluz
Copy link
Member

👍

Status: Reviewed

@mickaelandrieu I wasn't aware of this change and I like it! Thanks for your PR.

@wouterj
Copy link
Member

wouterj commented Jul 8, 2016

Great catch! Thanks Mickaël.

@wouterj wouterj merged commit 325ccb7 into symfony:3.1 Jul 8, 2016
wouterj added a commit that referenced this pull request Jul 8, 2016
…ndrieu)

This PR was merged into the 3.1 branch.

Discussion
----------

Updated the condition to display console name

Before `3.1` we need both console name and version in order to display the console name instead of `console tool`, now we only need to setup the name.

See symfony/console@56eb96d

Commits
-------

325ccb7 Updated the condition to display console name
@mickaelandrieu mickaelandrieu deleted the patch-2 branch July 8, 2016 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants