Skip to content

added app_ prefix to form type names #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
OskarStark wants to merge 1 commit into from
Closed

added app_ prefix to form type names #5798

OskarStark wants to merge 1 commit into from

Conversation

@OskarStark
Copy link
Contributor

@OskarStark OskarStark commented Oct 17, 2015

refs #5077

I'm not really sure about the changes of the alias names...

ping @xabbuh

Greetings from Symfony Live Berlin 2015 - Hack Day 😄

xabbuh
xabbuh reviewed Oct 17, 2015
View reviewed changes
book/forms.rst Outdated
Copy link
Member

@xabbuh xabbuh Oct 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not change this here (we already have the app. prefix).

Copy link
Member

@xabbuh xabbuh Oct 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same below

Copy link
Contributor Author

@OskarStark OskarStark Oct 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i changed the code

@xabbuh
Copy link
Member

xabbuh commented Oct 17, 2015

We should make this change in the 2.3 branch (the getName() method and the alias configuration will be gone in Symfony 3.0).

@OskarStark OskarStark force-pushed the streamline_form_type_names branch from 1e78371 to 2ef2567 Compare October 17, 2015 10:05
@OskarStark OskarStark force-pushed the streamline_form_type_names branch from 2ef2567 to 3fa821a Compare October 17, 2015 10:07
@OskarStark
Copy link
Contributor Author

OskarStark commented Nov 9, 2015

any news on this PR?

xabbuh
xabbuh reviewed Nov 12, 2015
View reviewed changes
cookbook/form/create_custom_field_type.rst
Copy link
Member

@xabbuh xabbuh Nov 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getName() bundle at the top of the article must be updated too.

@wouterj wouterj mentioned this pull request Dec 19, 2015
Merged
wouterj added a commit that referenced this pull request Dec 19, 2015
@wouterj
minor #6049 Finish #5798 Add app_ prefix to form type names (OskarSta…
eeb52b7 
…rk, WouterJ)

This PR was merged into the 2.3 branch.

Discussion
----------

Finish #5798 Add app_ prefix to form type names

Finishes #5798

Commits
-------

e47fa90 Updated getName() to return with app_ prefix
716a4f2 added app_ prefix to form type names
@wouterj
Copy link
Member

wouterj commented Dec 19, 2015

I've rebased this PR on top of 2.3 and updated the getName() method as indicated by @xabbuh in #6049 (which I just merged)

Thank you for fixing this @OskarStark! 🎄

@wouterj wouterj closed this Dec 19, 2015
@OskarStark
Copy link
Contributor Author

OskarStark commented Dec 19, 2015

Good Job 👍

Am Samstag, 19. Dezember 2015 schrieb Wouter J :

Closed #5798 #5798.

—
Reply to this email directly or view it on GitHub
#5798 (comment).

@OskarStark OskarStark deleted the streamline_form_type_names branch December 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OskarStark @xabbuh @wouterj