Skip to content

Conversation

@dejagersh
Copy link
Contributor

Hi,

I think this is a mistake in the docs. It shows App\Security\Attribute\IsSignatureValid whereas I think it should be Symfony\Component\HttpKernel\Attribute\IsSignatureValid

@carsonbot carsonbot changed the title Fix namespace of IsSignatureValid attribute in Routing docs Fix namespace of IsSignatureValid attribute in Routing docs Jan 9, 2026
Copy link
Contributor

@MrYamous MrYamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there is the same thing in another example at line 2706 maybe we can fix it too ?

homersimpsons and others added 4 commits January 12, 2026 15:30
…mersimpsons)

This PR was submitted for the 7.3 branch but it was merged into the 6.4 branch instead.

Discussion
----------

[Clock] Fix comment position in clock example

Commits
-------

60f3e16 Fix comment position in clock example
* 6.4:
  Fix comment position in clock example
* 7.3:
  Fix comment position in clock example
@carsonbot carsonbot changed the title Fix namespace of IsSignatureValid attribute in Routing docs [Security] Fix namespace of IsSignatureValid attribute in Routing docs Jan 12, 2026
@javiereguiluz javiereguiluz added this to the 7.4 milestone Jan 12, 2026
@javiereguiluz javiereguiluz changed the base branch from 8.0 to 7.4 January 12, 2026 14:33
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner January 12, 2026 14:33
@javiereguiluz javiereguiluz merged commit 4140d6d into symfony:7.4 Jan 12, 2026
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Johan! This is now merged in 7.4 branch and all the upper branches too.

Matthieu you are right. We did that change while merging. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants