[HttpClient] Improve the wording about asynchronous requests#21650
[HttpClient] Improve the wording about asynchronous requests#21650javiereguiluz merged 1 commit intosymfony:6.4from
Conversation
| Responses are always asynchronous, so that the call to the method returns | ||
| immediately instead of waiting to receive the response:: | ||
| Symfony's HTTP client is asynchronous by default. When you call ``request()``, | ||
| the HTTP request starts immediately, but the method returns without waiting for |
There was a problem hiding this comment.
| the HTTP request starts immediately, but the method returns without waiting for | |
| the HTTP request might start immediately, but the method returns without waiting for |
There was a problem hiding this comment.
But if we say "might start" ... then we need to explain when it starts and when it doesn't. Please, share some details about this. Thanks.
There was a problem hiding this comment.
I don't know, curl does. We don't care here, that's the whole point
There was a problem hiding this comment.
In which scenarios would the request doesn't start immediatly?
E.g. if there's no network connection or if it's saturated? I guess that's expected and it's a temporary or permanent issue ... but not relevant to this explanation. The request starts immediately but if there's a huge issue you'll get an exception and if there's a small issue, there will be some delay.
So, let's go ahead with the originally proposed wording? Thanks.
There was a problem hiding this comment.
It depends on the implementation for example. When using NativeHttpClient, it doesn't start immediately.
I'm fine keep as is, that's not critical either.
There was a problem hiding this comment.
OK, so let's merge this ... but of course we're open to change this in the future if we receive feedback from users thinking that the new description is not as precise as it should be 🙏 Thanks!
javiereguiluz
added
Waiting team decision
…tes for invokable commands (yceruto) This PR was merged into the 7.3 branch. Discussion ---------- [Console] Document `#[Argument]` and `#[Option]` attributes for invokable commands Fixes #21650 I kept both approaches for now so that later we can extract the classic approach into a new section as part of [https://github.com/symfony/symfony-docs/issues/21168](https://github.com/symfony/symfony-docs/issues/21168). Commits ------- 0a2c166 Document #[Argument] and #[Option] attributes for invokable commands
3 participants
A minor change to be more precise about the actual behavior of the HTTP client.