[Cache] Wrong callable in async cache computation example #21594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 25, 2025
Member
|
I guess this does also address the concerns raised in #20874? |
Contributor
Author
Yes, this is exactly the issue i had and would be fixed with this pr. |
javiereguiluz
force-pushed
the
improve_cache_async
branch
from
a5d58ca to
dcd2a12
Compare
Member
|
Thank you Marvin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already mentioned in #21587, but now with fix in 6.4 Branch with a reversible service.
I've noticed the fix for closures in early-expiration callbacks: symfony/symfony#62398 in 6.4 and 7.4 (RC2) which fixed my issue in the dev environment: #21587 (comment)