Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recipe for loophp/psr17 package. #1180

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Add recipe for loophp/psr17 package. #1180

merged 2 commits into from
Jul 29, 2021

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Jul 23, 2021 •
edited
Loading

ghost
ghost suggested changes Jul 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@github-actions
Copy link

github-actions bot commented Jul 23, 2021 •
edited
Loading

Diff between recipe versions

Thanks for the PR 😍

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

ghost
ghost approved these changes Jul 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@drupol drupol marked this pull request as ready for review July 23, 2021 09:40
ghost
ghost approved these changes Jul 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Jul 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Jul 23, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Nyholm
Nyholm approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@drupol
Copy link
Contributor Author

drupol commented Jul 26, 2021

Thanks !!!

@Nyholm
Copy link
Member

Nyholm commented Jul 26, 2021

@symfony-flex-server merge now

Nyholm
Nyholm approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge now

@drupol
Copy link
Contributor Author

drupol commented Jul 26, 2021 •
edited
Loading

sudo merge now ? 😆

@Nyholm
Copy link
Member

Nyholm commented Jul 26, 2021

It seams like I don’t have the power to merge it.

@drupol
Copy link
Contributor Author

drupol commented Jul 26, 2021

Ok...

@fabpot fabpot merged commit f78e1ce into symfony:master Jul 29, 2021
@Nyholm
Copy link
Member

Nyholm commented Jul 29, 2021

Wohoo. Thank you

@drupol drupol deleted the add-loophp-psr17 branch July 29, 2021 06:27
@drupol
Copy link
Contributor Author

drupol commented Jul 29, 2021

Merci :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drupol @Nyholm @fabpot