Add logging to Hub on update publish

[tostiheld]

In favour of #86 #SymfonyHackday

[tostiheld]

@dunglas CI is failing because of a coding standards check (inheritDoc should be removed from the Hub). Do you want me to ignore it or fix in a different PR?

[dunglas]

Suggested change

	"psr/log": "^1.0",
	"psr/log": "^1.0 || ^2.0 || ^3.0",

[dunglas]

Thanks! PR to fix the the CS is welcome.

[dunglas]

I would move the null check here to prevent a useless function call in case the logger isn't injected (this code may be in the hot path if the app sends a lof of updates):

Suggested change

	$this->logUpdate($update);
	if (null !== $this->logger) {
	$this->logUpdate($update);
	}

[dunglas]

IMHO it would be better to have only one entry in the logs instead of two, even in debug mode. What do you think about like that:

Suggested change

	$this->logger->info(
	sprintf(
	'Published update with ID \'%s\' on topic(s) [%s]',
	$update->getId(),
	implode(', ', $update->getTopics())
	),
	[
	'id' => $update->getId(),
	'topic' => $update->getTopics(),
	]
	);
	$this->logger->debug(
	sprintf('Debug details for update \'%s\'', $update->getId()),
	$this->updateToArray($update)
	);
	}
	$this->logger->info(
	sprintf(
	'Published update with ID "%s" on topic(s) [%s]',
	$update->getId(),
	implode(', ', $update->getTopics())
	),
	$this->debug ? $this->updateToArray($update) : [
	'id' => $update->getId(),
	'topic' => $update->getTopics(),
	] :
	);
	}

$this->debug will be a new promoted property defaulting to false in the component, and set to %kernel.debug% by the bundle.

This approach would also save 2 function calls in non-debug mode.