[make:auth] drop guard support and legacy code cleanup #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
force-pushed
the
legacy/make-user
branch
from
191ac3e to
2cf4e19
Compare
jrushlow
changed the title
jrushlow
force-pushed
the
legacy/make-user
branch
from
ec2d37e to
70238bc
Compare
1 task
weaverryan
reviewed
Apr 25, 2022
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Minor comments - it'll be great to remove all this old complexity!
src/Maker/MakeAuthenticator.php
Outdated
| $missingPackagesMessage = 'Twig and symfony/form must be installed to display the login form'; | ||
| } | ||
| $neededDependencies = [TwigBundle::class => 'twig', Form::class => 'symfony/form']; | ||
| $missingPackagesMessage = $this->addDependencies($neededDependencies, 'Twig and symfony/form must be installed to display the login form.'); |
Member
There was a problem hiding this comment.
I don't remember (and it's a bit old and hard to track down) the reason for the if (Kernel::VERSION_ID < 40100) { statement above, but I think you have it backwards. Previously, if the user's version was LESS than 4.1, symfony/form was installed. So, if 4.1 or greater, it is NOT required.
Collaborator
Author
There was a problem hiding this comment.
i cant remember either and grepping for symfony/form was - well.. ya.. haha removed, we'll see what the tests say..
jrushlow
force-pushed
the
legacy/make-user
branch
2 times, most recently
from
b7154af to
0cf32d3
Compare
weaverryan
reviewed
Apr 26, 2022
weaverryan
force-pushed
the
legacy/make-user
branch
from
6374e21 to
324f6f6
Compare
Member
|
Thanks Jesse! |
weaverryan
added a commit
that referenced
this pull request
May 3, 2022
This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [make:user] Legacy <= 5.3 & Doctrine Cleanup - `TemplateComponentGenerator::generateUseStatements()` can now handle use statements with aliases. - Add `doctrine/orm` conflict w/ `<2.10` - drop legacy Symfony < `5.4` Doctrine && User conditionals - remove legacy `UserBuilder` tests - fixes #990 - [x] Depends on #1104 Commits ------- e0c5f2b [make:user] Legacy <= 5.3 & Doctrine Cleanup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator::getControllerForBaseClass