Skip to content

Update ApiTestCase to be compliant with ApiPlatform v3.0 #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrushlow merged 1 commit into from
Feb 22, 2022
Merged

Update ApiTestCase to be compliant with ApiPlatform v3.0 #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Maker/MakeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@

namespace Symfony\Bundle\MakerBundle\Maker;

use ApiPlatform\Core\Bridge\Symfony\Bundle\Test\ApiTestCase;
use ApiPlatform\Core\Bridge\Symfony\Bundle\Test\ApiTestCase as LegacyApiTestCase;
use ApiPlatform\Symfony\Bundle\Test\ApiTestCase;
use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
use Symfony\Bundle\FrameworkBundle\Test\WebTestAssertionsTrait;
use Symfony\Bundle\MakerBundle\ConsoleStyle;
Expand Down Expand Up @@ -103,7 +104,7 @@ public function interact(InputInterface $input, ConsoleStyle $io, Command $comma
);
}

if ('ApiTestCase' === $input->getArgument('type') && !class_exists(ApiTestCase::class)) {
if ('ApiTestCase' === $input->getArgument('type') && !class_exists(ApiTestCase::class) && !class_exists(LegacyApiTestCase::class)) {
$io->warning([
'API Platform is required for this test type. Install it with',
'composer require api',
Expand Down Expand Up @@ -148,6 +149,7 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
[
'web_assertions_are_available' => trait_exists(WebTestAssertionsTrait::class),
'use_legacy_container_property' => $this->useLegacyContainerProperty(),
'api_test_case_fqcn' => \PHP_VERSION_ID < 80100 && !class_exists(ApiTestCase::class) ? LegacyApiTestCase::class : ApiTestCase::class,
]
);

Expand Down Expand Up @@ -186,7 +188,7 @@ public function configureDependencies(DependencyBuilder $dependencies, InputInte

case 'ApiTestCase':
$dependencies->addClassDependency(
ApiTestCase::class,
\PHP_VERSION_ID < 80100 && !class_exists(ApiTestCase::class) ? LegacyApiTestCase::class : ApiTestCase::class,
'api',
true,
false
Expand Down
2 changes: 1 addition & 1 deletion src/Resources/skeleton/test/ApiTestCase.tpl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace <?= $namespace; ?>;

use ApiPlatform\Core\Bridge\Symfony\Bundle\Test\ApiTestCase;
use <?= $api_test_case_fqcn; ?>;

class <?= $class_name ?> extends ApiTestCase
{
Expand Down