[make:controller][make:crud] Make route names start with 'app_'

[robmeijer]

This PR amends the route names generated by make:controller and make:crud by prepending them with app_.

This matches the route names generated by make:auth and make:registration-form.

[weaverryan]

This bothers me too :)

[weaverryan]

@robmeijer could you rebase? I've just merged a PR to get the tests in order (and running for Symfony 6). Thanks :)

[weaverryan]

Tests are failing due to some sloppy code that I probably wrote awhile ago :). This line -

maker-bundle/src/Test/MakerTestCase.php

Line 109 in 40b9b55

$serviceId = $serviceId ?? sprintf('maker.maker.%s', Str::asRouteName((new \ReflectionClass($makerClass))->getShortName()));

- should probably change to use asSnakeCase()

[robmeijer]

Tests are failing due to some sloppy code that I probably wrote awhile ago :). This line -

maker-bundle/src/Test/MakerTestCase.php

Line 109 in 40b9b55

$serviceId = $serviceId ?? sprintf('maker.maker.%s', Str::asRouteName((new \ReflectionClass($makerClass))->getShortName()));

• should probably change to use asSnakeCase()

eergh I was certain I checked usages of that method before changing it. Have pushed the suggested fix.

[jrushlow]

Thank you @robmeijer

[alexseif]

Hello, I wanted to ask you guys what do you think of this proposal? #1334