-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add options expansion to Add Lines Configuration #990
[Feature] Add options expansion to Add Lines Configuration #990
Conversation
1146790
to
bc440ea
Compare
Thanks for the PR. Can you please rebase it for branch 1.x? Please also revert the CS changes while doing so as 1.x still supports PHP 7.1 |
042764b
to
915e44f
Compare
Thanks for the suggestion! Questions:
The earliest occurance I found of this failure is here: https://github.com/symfony/flex/actions/runs/7101907556/job/19331086614 I've tried debugging this, but TBH I don't even know where to start (and when running the tests locally I had a different error) - do you have any suggestions where to look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nervemind the failures, they're false-positives.
023c975
to
644e426
Compare
Thank you @mnocon. |
Hi!
I've got a chance to play with the new AddLines configurator and it's an extremely useful feature, thanks for introducing it!
There is one small thing that seems missing to me: support for placeholders that are available in the
copy-from-package
andcopy-from-recipe
configurators.It's this feature:
(this text comes from https://github.com/symfony/recipes)
This small PR makes it possible to use placeholders in the add-lines configurator.
I'm not sure about the target branch, please let me know if I should rebase to 1.x - also not sure if I should mention it in the doc somewhere.