compare data before marking lock as changed #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
lockfix-v2
branch
from
e232267
to
bc400be
Compare
|
Thank you @stlrnz. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2019
This PR was squashed before being merged into the 1.5-dev branch. Discussion ---------- compare data before marking lock as changed In #479 I tried to fix the issue #379 by introducing a _changed_ flag to the Lock. This patch worked for a few months. However, introducing #576 broke the patch by [always calling](https://github.com/symfony/flex/pull/576/files#diff-46b78198ae7ea525f04268205dd782c3R273) `set` ending in the same situation as before. Blame on me for not checking if anything differs before setting the _changed_ flag. This PR tries to do better. Commits ------- bc400be compare data before marking lock as changed
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #479 I tried to fix the issue #379 by introducing a changed flag to the Lock.
This patch worked for a few months. However, introducing #576 broke the patch by always calling
setending in the same situation as before.Blame on me for not checking if anything differs before setting the changed flag. This PR tries to do better.