Fix dealing with locally patched packages #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nicolas-grekas. |
stof
reviewed
Jun 5, 2019
| @@ -78,6 +78,8 @@ public function removeLegacyTags(array $data): array | |||
| foreach ($versions as $version => $composerJson) { | |||
| if ('dev-master' === $version) { | |||
| $normalizedVersion = $this->versionParser->normalize($devMasterAlias); | |||
| } elseif (!isset($composerJson['version_normalized'])) { | |||
There was a problem hiding this comment.
why not attempting to read $composerJson['version'] and normalizing it (or just $version) ? We have access to the VersionParser to normalize here.
There was a problem hiding this comment.
because we don't really care: when this happens, we always want to keep the "version" anyway
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508
Happens on the CI when local packages are built for testing PRs.