Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with Symfony 7 #1006

Closed
wants to merge 1 commit into from

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Dec 23, 2023

PHP Fatal error:  Declaration of Symfony\Flex\Command\RecipesCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /home/runner/work/recipes/recipes/vendor/symfony/flex/src/Command/RecipesCommand.php on line 59
03:09:57 CRITICAL  [php] Fatal Compile Error: Declaration of Symfony\Flex\Command\RecipesCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int ["exception" => Symfony\Component\ErrorHandler\Error\FatalError { …}]

@xabbuh
Copy link
Member

xabbuh commented Dec 24, 2023

Should we do this on the 1.x branch and update the UnpackCommand class at the same time?

@fabpot
Copy link
Member

fabpot commented Dec 24, 2023

Should we do this on the 1.x branch and update the UnpackCommand class at the same time?

Yes, the 1.x branch is still maintained.

@shyim
Copy link
Contributor Author

shyim commented Jan 2, 2024

Can we get this merged and released? It's blocking our pipeline 😅

fabpot added a commit that referenced this pull request Jan 2, 2024
This PR was merged into the 1.x branch.

Discussion
----------

fix compatibility with Symfony 7

fix for 1.x #1006

Commits
-------

77e7ba3 fix compatibility with Symfony 7
@fabpot
Copy link
Member

fabpot commented Jan 2, 2024

Done when I merged 1.x into 2.x via #1007

@fabpot fabpot closed this Jan 2, 2024
@fabpot
Copy link
Member

fabpot commented Jan 2, 2024

@shyim Releases done :)

@shyim
Copy link
Contributor Author

shyim commented Jan 2, 2024

@fabpot the 2.x release seems missing 😅

@shyim shyim deleted the fix-crash-with-symfony-7 branch January 2, 2024 14:42
@fabpot
Copy link
Member

fabpot commented Jan 2, 2024

@fabpot the 2.x release seems missing 😅

Oops, my bad, should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants