-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Symfony 7.2 #1532
Upgrade to Symfony 7.2 #1532
Conversation
The only important requirement for this project is that it must be fully usable without doing anything (run no commands, change no config option, etc.) A user runs In |
csrf_protection should be enabled by default, so everything should work after a create-project |
OK, thanks. Can you please fix the linter issues? Then, I'll merge this. Thanks. |
The |
Possibly @stof. The second argument still holds :) |
your second argument made me realize a big shortcoming of your new Flex feature (I commented at symfony/flex#1028 (comment) as this belongs to Flex). |
Btw, your hack would be a pain to maintain as this manual removal will have to be re-applied each time someone contributes an update. |
a193630
to
f3021bf
Compare
CI fixed @javiereguiluz
@stof let's see. This should be manageable IMHO. |
@nicolas-grekas it would be very easy for contributors to submit an updated symfony.lock that would be missed during code review (especially given it is collapsed by default). |
We need to be careful indeed. |
Well, in Flex, you are suggesting to use |
Vote pending BTW on that PR :) But this PR on flex won't solve the issue you're raising about maintainability: we'll still want flex to generate a new secret when the demo is installed, and the only way to do so it to run the fwb recipe at installation time, aka not commit the recipe in symfony.lock. |
Thanks Nicolas! |
This PR is based on #1529 with the following changes: