This repository was archived by the owner on Sep 16, 2021. It is now read-only.
split up configuration into methods #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Do we need docblock for the sub-methods?
Member
|
@dbu looks cool. Except my question about the docblocks, we can merge it. |
Member
Author
|
renamed the methods to configure... and added docblocks. |
Member
|
The convention in Symfony core is to name these methods "addXxxSection" |
Member
Author
|
oh, ok. makes sense. i was looking at the doctrine bundle as inspiration. but addXxSection sounds good, will change to that |
Member
Author
|
and pushed again with the better names |
Member
|
its awesome how big that configuration grews up. |
Member
|
@dbu i just restarted the job, cause i don't understand the reason. The test failed just on php 5.6 and Symfony 2.3.* |
Member
|
whaat was the change? |
ElectricMaxxx
added a commit
that referenced
this pull request
Jul 31, 2015
split up configuration into methods
Member
|
thanks @dbu |
Member
Author
|
no change. just restarted once more. no idea how that happened. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i want to improve on #245 but notice that the configuration being one huge spaghetti is starting to get into the way. this PR changes no functionality at all, just splits the configuration tree building into separate sections. can we do this? then i will rebase #245 and try to push validation into the configuration definition.