Skip to content

[TASK] Add type hints to ScriptHandler #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2016
Merged

[TASK] Add type hints to ScriptHandler #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Composer/ScriptHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
*/

namespace Symfony\Cmf\Bundle\CreateBundle\Composer;
use Composer\Script\Event;

use Symfony\Component\Process\Process;

Expand All @@ -26,13 +27,13 @@ class ScriptHandler

const CKEDITOR_COMMIT_ID = '0fb9d534634a06af386027bd7dea2c9dcfb8bb99';

public static function downloadCreateAndCkeditor($event)
public static function downloadCreateAndCkeditor(Event $event)
{
ScriptHandler::downloadCreate($event);
ScriptHandler::downloadCkeditor($event);
}

public static function downloadCreate($event)
public static function downloadCreate(Event $event)
{
$extra = $event->getComposer()->getPackage()->getExtra();
$event->getIO()->write("<info>Download or update create</info>");
Expand Down Expand Up @@ -61,7 +62,7 @@ public static function downloadCreate($event)
ScriptHandler::gitSynchronize($directory, $repository, $commit);
}

public static function downloadCkeditor($event)
public static function downloadCkeditor(Event $event)
{
$extra = $event->getComposer()->getPackage()->getExtra();
$event->getIO()->write("<info>Download or update ckeditor</info>");
Expand Down