Skip to content

Conversation

@dbu
Copy link
Member

@dbu dbu commented Dec 18, 2015

backport 894bd1c as per Sylius/Sylius#3389

@lsmith77
Copy link
Member

can you also back port the memory limit fix for PHP 5.3?

lsmith77 added a commit that referenced this pull request Dec 26, 2015
Add an optional dependency on jms/serializer-bundle
@lsmith77 lsmith77 merged commit 86a3ade into 1.2 Dec 26, 2015
@lsmith77 lsmith77 deleted the backport-jms-serializer branch December 26, 2015 09:43
@lsmith77 lsmith77 removed the review label Dec 26, 2015
@afoeder
Copy link
Contributor

afoeder commented Jan 12, 2016

This breaks B/C as of

PHP Fatal error: Class 'JMS\SerializerBundle\JMSSerializerBundle' not found in ..../app/AppKernel.php on line 40

40: new JMS\SerializerBundle\JMSSerializerBundle($this)

Took me a while to find out what package was responsible for making the SerializerBundle vanish suddenly... What is the suggested action? Shall users add it to the project's composer.json?

@lsmith77
Copy link
Member

yes .. sorry about that. we should have used a suggest from the beginning as there are a lot of features in this Bundle that do not require serialization

@afoeder
Copy link
Contributor

afoeder commented Jan 12, 2016

So the least friction for running projects would be to put

"jms/serializer-bundle": "^0.12|^1.0"

to the {{requires}} section in the project's root composer.json wouldn't it?

@lsmith77
Copy link
Member

the least friction would be: "jms/serializer-bundle": "^0.12"
but I would very much recommend going to "jms/serializer-bundle": "^1.0" instead and spending some extra time to validate that the update is fine

@afoeder
Copy link
Contributor

afoeder commented Jan 12, 2016

👍 thanks @lsmith77 I did the 1.0 thingie and so far it worked out well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants