Add --open flag to server:start command
#668
Conversation
Kocal
changed the title
--open flag to server:start command
|
I'm not sure I'd like to always open a browser. |
|
I think it depends on what kind of project you're working. Indeed that's not useful for an API-oriented application, but it is for a Twig-based app. I've worked on quite a few JavaScript projects (mostly based on Vite), and having the app open automatically in the browser was super convenient. Here, the option is disabled by default, and it helps to resolves #639 (where you have to scroll a tons of log to find the application URL). I think that's fine? |
| func abstractOpenCmd(url string) { | ||
| if err := open.Run(url); err != nil { | ||
| terminal.Eprintln("<error>Error while opening:", err, "</>") | ||
| terminal.Eprintfln("Please visit <href=%s>%s</> manually.", url, url) | ||
| } else { | ||
| terminal.Eprintfln("Opened: <href=%s>%s</>", url, url) | ||
| } | ||
| } |
There was a problem hiding this comment.
Opening an URL does not really makes sense outside of an interactive context (ie when running a command). So I would not move it to utils.
There was a problem hiding this comment.
Yeah I wasn't really sure, I just wanted to centralize this logic
There was a problem hiding this comment.
I wasn't sure where to put it, so I simply reverted my changes and duplicated the block to open the URL in the browser
|
I think I agree with @fabpot here: while I see the use of the |
|
A setting
Why can't we add it to the Symfony CLI? |
|
I'm not saying we can't, I'm saying I'm not sure this is that useful (again in the configuration as I'm convinced of the flag. Because from experience I usually do something like But I'm not against having it |
|
I'm fine adding the |
Kocal
force-pushed
the
feat/server-start-open
branch
from
ee0faee to
88da774
Compare
|
I just removed the |
|
It is if you are the same package (ie. directory)
… Message ID: ***@***.***
com>
|
Kocal
force-pushed
the
feat/server-start-open
branch
from
88da774 to
c2ead21
Compare
local/project/config.go
Outdated
|
|
||
| NoWorkers bool | ||
| Daemon bool | ||
| Open bool |
There was a problem hiding this comment.
This should not be part of the config. Instead, you should create a flag in the server:start command directly.
There was a problem hiding this comment.
Ah, yes, there's no need for that anymore.
Fixed!
Kocal
force-pushed
the
feat/server-start-open
branch
from
c2ead21 to
7cbdcd8
Compare
Kocal
force-pushed
the
feat/server-start-open
branch
from
7cbdcd8 to
1522ce6
Compare
|
Thank you @Kocal. |
3 participants
Related to #639
Passing the flag
--opentosymfony serveorsymfony server:startopen the first reachable URL in the default web-browser.