Fix Password field

(all CMS .js is in a bundle, so this needed to be extracted)

client/javascript/ConfirmedPasswordField.js

@@ -0,0 +1,14 @@
+/* extracted from silverstripe/framework */
+
+(function ($) {
+  $(document).on('click', '.confirmedpassword .showOnClick a', function () {
+    var $container = $('.showOnClickContainer', $(this).parent());
+
+    $container.toggle('fast', function() {
+      $container.find('input[type="hidden"]').val($container.is(":visible") ? 1 : 0);
+    });
+
+    return false;
+  })
+  .find(".confirmedpassword .showOnClickContainer").hide();
+})(jQuery);

src/Pages/MemberProfilePageController.php

@@ -15,6 +15,7 @@
 use SilverStripe\Control\Email\Email;
 use SilverStripe\SiteConfig\SiteConfig;
 use SilverStripe\Forms\LiteralField;
+use SilverStripe\View\Requirements;
 use Symbiote\MemberProfiles\Pages\MemberProfilePage;
 use Symbiote\MemberProfiles\Pages\MemberProfileViewer;
 use Symbiote\MemberProfiles\Email\MemberConfirmationEmail;
@@ -519,8 +520,13 @@ protected function getProfileFields($context) {
 				$field = $field->performReadonlyTransformation();
 			}
 
-			$field->setTitle($profileField->Title);
-			$field->setDescription($profileField->Note);
+			if($name == 'Password') {
+                Requirements::javascript("memberprofiles/client/javascript/ConfirmedPasswordField.js");
+            }
+
+            // The follow two if-conditions were added since the SS4 migration because a Password label disappeared
+			if($profileField->Title) $field->setTitle($profileField->Title);
+            if($profileField->Note) $field->setDescription($profileField->Note);
 
 			if($context == 'Registration' && $profileField->DefaultValue) {
 				$field->setValue($profileField->DefaultValue);