Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy file path #62

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Add copy file path #62

merged 2 commits into from
Jan 7, 2023

Conversation

kropptrevor
Copy link
Contributor

Implements #36

In the right click menu:

Copy to clipboard Ctrl+C
Copy original size image Ctrl+X
Copy file path
Paste from clipboard Ctrl+V

I wasn't sure what the default key binding would be. Any suggestions?

@sylikc
Copy link
Owner

sylikc commented May 26, 2022

Interesting... I like this feature, and you've added it pretty cleanly

@sylikc sylikc added the enhancement New feature or request label May 26, 2022
@Bobbsterman
Copy link

Nice!
I would go with some modification of C. E.g. Ctrl+Shift+C

@kropptrevor
Copy link
Contributor Author

I've added a shortcut and an entry in the help screen. I did not provide translations, however.

@Bobbsterman
Copy link

Nice. Lets hope @sylikc finds time to pull some of these enhancements!

I can provide a French translation:
"copy image path to clipboard" = "copier l'emplacement de l'image"

@sylikc
Copy link
Owner

sylikc commented Jan 7, 2023

@Bobbsterman I'm merging this PR... the exact translation strings are right now are

"Copy file path of the image to clipboard"
and "Copy file path"

I'll roll them in when you translate. Some of the translation stuff also needs to get cleaned up as per #105

sylikc added a commit that referenced this pull request Jan 7, 2023
@sylikc sylikc merged commit fc342cf into sylikc:master Jan 7, 2023
@sylikc
Copy link
Owner

sylikc commented Jan 7, 2023

@kropptrevor thanks for the contribution. This will likely end up being a feature I use almost daily!

Certainly was helpful to review your code, where I forgot to put help in my "Open containing folder in Explorer" feature, and forgot to disable it for clipboard images. 65e7905

FYI: I fixed the Russian translation file getting mangled and also the popup menu bug a326463

@kropptrevor
Copy link
Contributor Author

That's good to hear. I'm happy to have contributed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants