Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add an option in JPEGView.ini to set HighQualityResampling for only downsampling #19

Closed
OCD-Man opened this issue Sep 17, 2021 · 9 comments
Labels
backlog This isn't a priority add/fix at this time config opts Related to configuration options, config files, or keymap files enhancement New feature or request

Comments

@OCD-Man
Copy link

OCD-Man commented Sep 17, 2021

Please consider adding an option in JPEGView.ini for the HighQualityResampling setting to be set to "downsample" so it only downlsamples when the image is zoomed out to less than a 1:1 ratio, and so upsampling is disabled when zooming in to more than 1:1 ratio.

The only use I have for zooming in to an image to larger than 1:1 is to be able to see the individual pixels to compare them to another differently compressed copy of the same image. But if I set HighQualityResampling to false, then when the image is zoomed out to smaller than 1:1, the resampling looks incredibly horrible.

I am trying to replace my usage of Windows 7 photo viewer with JPEGView, and photo viewer downsamples and doesn't upsample, which is the way I need it to be.

I hope you can add this option for me as well as fix the last issue I posted (#14) for your next update. With these 2 things fixed, I can feel comfortable setting JPEGView as my default image viewer, and I will just use something else for images with transparency until support for transparency is added to all of the image formats that don't yet support it.

@sylikc sylikc added the enhancement New feature or request label Feb 11, 2022
@kevinfiol
Copy link

First off; thanks for picking up development on JPEGView. It has been my favorite photo viewer for Windows.

I do want to +1 this issue as I recently started working with pixel art and graphics, and while the HighQualityResampling set to true is wonderful for my photo collection, it makes viewing pixel art impossible. For the time being, I have switched to qimgv although it is noticeably slower than JPEGView.

@Hrxn
Copy link

Hrxn commented Oct 23, 2022

Haven't tried this fork yet, but I see no change that would make it impossible to use a JPEGView.ini config file just like before?

Just use the context menu, configuration section, and open the .ini file from there (should be created automatically, if not existing yet).. then simply edit the file yourself, e.g. by setting HighQualityResampling to false, for example?

@kevinfiol
Copy link

Haven't tried this fork yet, but I see no change that would make it impossible to use a JPEGView.ini config file just like before?

Just use the context menu, configuration section, and open the .ini file from there (should be created automatically, if not existing yet).. then simply edit the file yourself, e.g. by setting HighQualityResampling to false, for example?

Not sure on the technicals, but the issue is exactly that. If I set it to false, pixel art looks great, but photos look terrible. If set to true, vice versa.

This issue does not exist on qimgv or XnView Classic.

@Hrxn
Copy link

Hrxn commented Oct 23, 2022

Ah, I know what you mean now. This is a feature request for a new resampling option that does not exist yet, neither in the fork, nor the original project.
Fair enough.
I mean, you can always toggle high quality resampling with F3, but I see how setting this automatically based on zoom level and image dimensions would be advantageous.

@sylikc
Copy link
Owner

sylikc commented Jan 27, 2023

Interesting... Let me look into this. I don't know if it's easy to add though. The redrawing graphics routines are pretty complex.

@sylikc sylikc added the config opts Related to configuration options, config files, or keymap files label Feb 13, 2023
@sylikc sylikc added the backlog This isn't a priority add/fix at this time label Feb 22, 2023
@sylikc
Copy link
Owner

sylikc commented Mar 5, 2023

After the AVX2 bugfix, I've gotten a bit more familiar with the Resample routine...

I'm testing a DownSample addition for the next release

sylikc added a commit that referenced this issue Mar 5, 2023
This allows smoothing when zoomed out, but zooming in would allow seeing actual pixels (pixel peeping)

#19 only requests downsample, but if one adds down, why not also add up?

Current changes do not write to parameters DB, means it would default to BOTH when using Parameters DB
@sylikc
Copy link
Owner

sylikc commented Mar 5, 2023

@OCD-Man this is implemented in the branch right now... I need to do more testing to verify it actually works as expected.

Can you pull a Development snapshot for resample-up-down branch (howto use Dev Snapshots) for that branch to see if it works as expected? Use the modified HighQualityResampling INI option to test. Also if you have suggestions for text to describe the feature, let me know. I tried the best I could to explain in the INI why one would want to use DownSample or UpSample only.

@alexgoulden
Copy link

alexgoulden commented May 14, 2023

Hey, just crossposting from #192 to confirm this works as expected and exactly what I was looking for, the description is accurate as is and I don't think it needs updating.

@OCD-Man this is implemented in the branch right now... I need to do more testing to verify it actually works as expected.

Can you pull a Development snapshot for resample-up-down branch (howto use Dev Snapshots) for that branch to see if it works as expected? Use the modified HighQualityResampling INI option to test. Also if you have suggestions for text to describe the feature, let me know. I tried the best I could to explain in the INI why one would want to use DownSample or UpSample only.

@sylikc
Copy link
Owner

sylikc commented Oct 6, 2023

I think this is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog This isn't a priority add/fix at this time config opts Related to configuration options, config files, or keymap files enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants