Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add +tools/lsp-python layer #10241

Closed
wants to merge 4 commits into from
Closed

Add +tools/lsp-python layer #10241

wants to merge 4 commits into from

Conversation

casouri
Copy link
Contributor

@casouri casouri commented Jan 24, 2018

With ongoing support of lsp layer in #10211, I think I can contribute something to lsp-python layer.
This layer is depend on lsp layer. Because I really just a beginner, python-language-server needs to be installed manually by user using pip. But no other configuration is needed.

The functionality is not as versatile as python layer, but most of the daily functionalities are covered well. Autocompletion, jumping, executing script, doc, etc are all covered.

@casouri
Copy link
Contributor Author

casouri commented Jan 24, 2018

Ok it seems the problem is readme.org, I tried to fix it.

@casouri casouri changed the title Add lsp-python layer Add +tools/lsp-python layer Jan 24, 2018
I added quickrun package to execute python script with ease.
It is owned by lsp-python since no one is using this great package in other layers.
@syl20bnr syl20bnr self-assigned this Feb 19, 2018
@syl20bnr
Copy link
Owner

Thank you ! 👍

I added LSP support directly to the python layer in commit 81a931f4

I merged your PR but deleted the lsp-python layer in the above commit as it is not needed anymore.
See updated README.org of python layer to learn how to enable LSP.

Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Feb 19, 2018
@syl20bnr syl20bnr removed the Merged label Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants