[DRAFT] Compute real deposit signatures when BLS verification is disabled - #1
Draft
syjn99 wants to merge 1 commit into
Draft
[DRAFT] Compute real deposit signatures when BLS verification is disabled#1syjn99 wants to merge 1 commit into
syjn99 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar motivation with ethereum#5489 and mirrors it. An invalid deposit signature does not invalidate the block - the deposit is silently skipped - so its validity is reflected in the
BeaconState.bls_setting: 2currently makes fixture use stub deposit signatures, so the expected post-state depends on how the client handles BLS-off mode. In Prysm, we always verify deposit signatures, so the deposit created in the test liketest_is_one_confirmed_fails_recently_activated_validator_voting_in_empty_slotfails because of state root validation. I guess Lodestar has similar problem with us, currently just skipping the test attributing the reason to their FCR implementation.The alternative - clients disabling all BLS verification under
bls_setting: 2- would require a test-only hook inside production deposit processing in every client, because deposit signature validity is a state-transition branch rather than a verification gate. With this change the vectors remainbls_setting: 2(block signatures are still stubs) - only the signature whose validity selects state content is real.Related to ethereum#5489 and follow up of ethereum#5400. Verified with Prysm
fcrbranch (PR), as the following tests pass when new fixture is generated based on the change that this PR will bring:test_is_one_confirmed_fails_recently_activated_validator_voting_in_empty_slottest_is_one_confirmed_passes_with_new_validator_activated_in_head_state