Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for different fees per dest domain to basic/percentage fee handler #206

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

nmlinaric
Copy link
Contributor

Description

This introduces a mapping for fees per destination domain. Now we don't have to deploy a new handler for every fee amount, they all can be setup in a single basic/percentage fee handler.

Also removes setting up fees in migrations since now there would be too many moving parts to do it automatically.
In general we need to rethink about fees and how to approach to migrations.

Related Issue Or Context

Closes: #205
Closes: #151

How Has This Been Tested? Testing details.

existing unit and e2e tests are updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric changed the title Add support for different fees per dest domain to basic/percentage fee handler feat: add support for different fees per dest domain to basic/percentage fee handler Oct 19, 2023
@nmlinaric nmlinaric force-pushed the nmlinaric/fee-handlers-refactor branch from 14dac76 to 44ced8c Compare October 20, 2023 08:44
contracts/handlers/fee/BasicFeeHandler.sol Outdated Show resolved Hide resolved
contracts/handlers/fee/BasicFeeHandler.sol Outdated Show resolved Hide resolved
@nmlinaric nmlinaric merged commit 944d4ee into master Oct 31, 2023
5 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/fee-handlers-refactor branch October 31, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants